[PATCH 3/4] video: mxsfb: add clk_enable()

Fabio Estevam festevam at gmail.com
Mon Apr 27 01:48:11 CEST 2020


Hi Giulio,

On Sun, Apr 26, 2020 at 8:43 PM Giulio Benetti
<giulio.benetti at benettiengineering.com> wrote:

> +       ret = clk_enable(&per_clk);
> +       if (ret < 0) {
> +               dev_err(dev, "Failed to enable mxs clk: %d\n", ret);
> +               return;
> +       }
> +
>         ret = clk_set_rate(&per_clk, timings->pixelclock.typ);
>         if (ret < 0) {
>                 dev_err(dev, "Failed to set mxs clk: %d\n", ret);

Usually it is safer to configure the clock rate first and then enable
the clock to avoid glitches.

Could you try to call clk_enable() after clk_set_rate() here?


More information about the U-Boot mailing list