[PATCH 3/4] video: mxsfb: add clk_enable()

[Giulio Benetti]

Hi Fabio,

On 4/27/20 1:48 AM, Fabio Estevam wrote:
> Hi Giulio,
> 
> On Sun, Apr 26, 2020 at 8:43 PM Giulio Benetti
> <giulio.benetti at benettiengineering.com> wrote:
> 
>> +       ret = clk_enable(&per_clk);
>> +       if (ret < 0) {
>> +               dev_err(dev, "Failed to enable mxs clk: %d\n", ret);
>> +               return;
>> +       }
>> +
>>          ret = clk_set_rate(&per_clk, timings->pixelclock.typ);
>>          if (ret < 0) {
>>                  dev_err(dev, "Failed to set mxs clk: %d\n", ret);
> 
> Usually it is safer to configure the clock rate first and then enable
> the clock to avoid glitches.
> 
> Could you try to call clk_enable() after clk_set_rate() here?

Sure, I'm going to send it for V2.

Thanks for reviewing
-- 
Giulio Benetti
Benetti Engineering sas