[PATCH 1/6] clk: actions: Introduce dummy get/set_rate callbacks

André Przywara andre.przywara at arm.com
Mon Dec 14 02:14:50 CET 2020


On 13/12/2020 09:43, Amit Singh Tomar wrote:
> This commit introduces get/set_rate callbacks, these are dummy at
> the moment, and can be used to get/set clock for various devices
> based on the clk id.
> 
> Signed-off-by: Amit Singh Tomar <amittomer25 at gmail.com>
> ---
>  drivers/clk/owl/clk_owl.c | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/drivers/clk/owl/clk_owl.c b/drivers/clk/owl/clk_owl.c
> index 1999c87..c9bc5c2 100644
> --- a/drivers/clk/owl/clk_owl.c
> +++ b/drivers/clk/owl/clk_owl.c
> @@ -128,6 +128,32 @@ int owl_clk_disable(struct clk *clk)
>  	return 0;
>  }
>  
> +static ulong owl_clk_get_rate(struct clk *clk)
> +{
> +	struct owl_clk_priv *priv = dev_get_priv(clk->dev);

This is a bit premature and leads to compilation warnings.

> +	ulong rate;
> +
> +	switch (clk->id) {
> +	default:
> +		return -ENOENT;
> +	}
> +
> +	return rate;
> +}
> +
> +static ulong owl_clk_set_rate(struct clk *clk, ulong rate)
> +{
> +	struct owl_clk_priv *priv = dev_get_priv(clk->dev);

Same here.

Cheers,
Andre

> +	ulong new_rate;
> +
> +	switch (clk->id) {
> +	default:
> +		return -ENOENT;
> +	}
> +
> +	return new_rate;
> +}
> +
>  static int owl_clk_probe(struct udevice *dev)
>  {
>  	struct owl_clk_priv *priv = dev_get_priv(dev);
> @@ -145,6 +171,8 @@ static int owl_clk_probe(struct udevice *dev)
>  static const struct clk_ops owl_clk_ops = {
>  	.enable = owl_clk_enable,
>  	.disable = owl_clk_disable,
> +	.get_rate = owl_clk_get_rate,
> +	.set_rate = owl_clk_set_rate,
>  };
>  
>  static const struct udevice_id owl_clk_ids[] = {
> 



More information about the U-Boot mailing list