[PATCH 1/6] clk: actions: Introduce dummy get/set_rate callbacks

Amit Tomer amittomer25 at gmail.com
Mon Dec 14 15:16:21 CET 2020


Hi,

On Mon, Dec 14, 2020 at 6:45 AM André Przywara <andre.przywara at arm.com> wrote:
>
> On 13/12/2020 09:43, Amit Singh Tomar wrote:
> > This commit introduces get/set_rate callbacks, these are dummy at
> > the moment, and can be used to get/set clock for various devices
> > based on the clk id.
> >
> > Signed-off-by: Amit Singh Tomar <amittomer25 at gmail.com>
> > ---
> >  drivers/clk/owl/clk_owl.c | 28 ++++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >
> > diff --git a/drivers/clk/owl/clk_owl.c b/drivers/clk/owl/clk_owl.c
> > index 1999c87..c9bc5c2 100644
> > --- a/drivers/clk/owl/clk_owl.c
> > +++ b/drivers/clk/owl/clk_owl.c
> > @@ -128,6 +128,32 @@ int owl_clk_disable(struct clk *clk)
> >       return 0;
> >  }
> >
> > +static ulong owl_clk_get_rate(struct clk *clk)
> > +{
> > +     struct owl_clk_priv *priv = dev_get_priv(clk->dev);
>
> This is a bit premature and leads to compilation warnings.

Sorry, I should have compile-tested the individual commit as well.
I Would fix it in the next version.

Thanks
-Amit


More information about the U-Boot mailing list