[PATCH 2/4] mmc: davinci: drop struct davinci_mmc_plat

Adam Ford aford173 at gmail.com
Fri Jan 3 18:26:33 CET 2020


On Fri, Jan 3, 2020 at 10:59 AM Tom Rini <trini at konsulko.com> wrote:
>
> On Fri, Jan 03, 2020 at 05:50:38PM +0100, Bartosz Golaszewski wrote:
> > pt., 3 sty 2020 o 17:01 Adam Ford <aford173 at gmail.com> napisaƂ(a):
> > >
> > > On Thu, Nov 14, 2019 at 9:10 AM Bartosz Golaszewski <brgl at bgdev.pl> wrote:
> > > >
> > > > From: Bartosz Golaszewski <bgolaszewski at baylibre.com>
> > > >
> > > > struct mmc_config & struct mmc don't need to be exported over platform
> > > > data, but can instead be private in the driver.
> > > >
> > > > Remove struct davinci_mmc_plat.
> > >
> > > This patch appears to break the da850-evm.
> > >
> > > With the pending release of 2020.01, is there any way we can revert
> > > before release and try to apply this going forward with more time to
> > > test?
> > >
> > > As of now, the da850-evm cannot read/write from the MMC card from
> > > U-Boot which includes MMC booting.
> > >
> >
> > This is strange, this change doesn't seem to affect the logic.
> >
> > This isn't revertible automatically anymore, due to other patches that
> > came before and after. We can probably try to revert it manually.
>
> Doing a git revert and fixing up the one hunk that didn't go cleanly is
> easy, should I push that?

That would make me happy.  :-)  I don't know about Bartosz.

If you have a patch, I can quickly test it today.

adam
>
> --
> Tom


More information about the U-Boot mailing list