[PATCH] riscv: Try to get cpu frequency from device tree
Lukas Auer
lukas at auer.io
Sun Jan 26 23:26:28 CET 2020
On Sun, 2020-01-26 at 13:20 -0500, Sean Anderson wrote:
> On 1/26/20 11:34 AM, Lukas Auer wrote:
> > Hi Sean,
> > Usually, ret is used as a variable name here. I think it would actually
> > make the code a bit nicer to read here, because the clock rate is not
> > read from variable err.
>
> Hm, I chose err instead of ret since that variable is never the return
> value of the function. I can change that for v2 if you'd like.
>
Makes sense. I think it's fine to keep it as is.
> > But that's just nit-picking. The patch looks good otherwise!
> >
> > Reviewed-by: Lukas Auer <lukas at auer.io>
>
>
More information about the U-Boot
mailing list