[PATCH] riscv: Try to get cpu frequency from device tree

[Rick Chen]

Hi Sean

> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Lukas Auer
> Sent: Monday, January 27, 2020 6:26 AM
> To: u-boot at lists.denx.de; seanga2 at gmail.com
> Subject: Re: [PATCH] riscv: Try to get cpu frequency from device tree
>
> On Sun, 2020-01-26 at 13:20 -0500, Sean Anderson wrote:
> > On 1/26/20 11:34 AM, Lukas Auer wrote:
> > > Hi Sean,
> > > Usually, ret is used as a variable name here. I think it would
> > > actually make the code a bit nicer to read here, because the clock
> > > rate is not read from variable err.
> >
> > Hm, I chose err instead of ret since that variable is never the return
> > value of the function. I can change that for v2 if you'd like.
> >
>
> Makes sense. I think it's fine to keep it as is.

But this patch seem depend on [PATCH v2 06/11] riscv: Fix incorrect
cpu frequency on RV64.
Can you combine those two patches as one patch-set and also modify err
as ret BTW.

Thanks
Rick

>
> > > But that's just nit-picking. The patch looks good otherwise!
> > >
> > > Reviewed-by: Lukas Auer <lukas at auer.io>