[PATCH] video: extend stdout video console work-around for 'vga'

Patrick DELAUNAY patrick.delaunay at st.com
Wed Jul 1 15:01:43 CEST 2020


Hi Anatolij

> From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Anatolij Gustschin
> Sent: vendredi 19 juin 2020 15:56
> 
> On Sat, 23 May 2020 17:11:20 +0200
> Anatolij Gustschin agust at denx.de wrote:
> 
> > cfb_console driver use 'vga' console name and we still have board
> > environments defining this name. Re-use existing DM_VIDEO work- around
> > for console name to support 'vga' name in stdout environment.
> >
> > Signed-off-by: Anatolij Gustschin <agust at denx.de>
> > ---
> >  arch/arm/mach-tegra/Kconfig |  1 -
> >  common/console.c            |  7 ++++---
> >  drivers/video/Kconfig       | 16 +++++++++-------
> >  3 files changed, 13 insertions(+), 11 deletions(-)
> 
> Applied to u-boot-video/next, thanks!

This patch breaks the stm32mp15 boot in console_init_r.on the next branch.

The board have with DM_VIDEO activated.
In previous version the workaround was not activated for the board: CONFIG_VIDCONSOLE_AS_LCD=n (default)

PS: the config is activated  in few board but still as bolean but defined as sting in Kconfig
	configs/peach-pit_defconfig:76:CONFIG_VIDCONSOLE_AS_LCD=y
	configs/snow_defconfig:87:CONFIG_VIDCONSOLE_AS_LCD=y
	configs/peach-pi_defconfig:77:CONFIG_VIDCONSOLE_AS_LCD=y
	configs/spring_defconfig:88:CONFIG_VIDCONSOLE_AS_LCD=y

Now it is a string, the CONFIG is always defined = value is "lcd" or "vga" or ""

And the code in console.c under this compilation flags cause the crash.

I push a patch [1]  to fix up it this update: 

VIDCONSOLE_AS_LCD => Boolean  used in defconfig as previously
VIDCONSOLE_AS_NAME => name the the string to used.... NEW

[1]  "video: restore CONFIG_VIDCONSOLE_AS_LCD as Boolean"

Regards

Patrick



More information about the U-Boot mailing list