[PATCH v1 41/43] x86: acpi: Correct the version of the MADT

[Wolfgang Wallner]

Hi Simon,

-----"Simon Glass" <sjg at chromium.org> schrieb: -----
> Betreff: [PATCH v1 41/43] x86: acpi: Correct the version of the MADT
> 
> Currently U-Boot implements version 2 but reports version 4. Correct it.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
>  arch/x86/lib/acpi_table.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/lib/acpi_table.c b/arch/x86/lib/acpi_table.c
> index b6ba547b6a..6e3276c6f6 100644
> --- a/arch/x86/lib/acpi_table.c
> +++ b/arch/x86/lib/acpi_table.c
> @@ -155,7 +155,7 @@ static void acpi_create_madt(struct acpi_madt *madt)
>  	/* Fill out header fields */
>  	acpi_fill_header(header, "APIC");
>  	header->length = sizeof(struct acpi_madt);
> -	header->revision = 4;
> +	header->revision = 2;

Nit:
Commit 91fe8b79f691 ("acpi: Add a central location for table version number")
has introduced defines for the different MADT revision numbers in
include/acpi/acpi_table.h, e.g. ACPI_MADT_REV_ACPI_3_0 for the value 2.

Could you use this instead of the hardcoded value 2?

>  
>  	madt->lapic_addr = LAPIC_DEFAULT_BASE;
>  	madt->flags = ACPI_MADT_PCAT_COMPAT;
> -- 
> 2.27.0.290.gba653c62da-goog

Reviewed-by: Wolfgang Wallner <wolfgang.wallner at br-automation.com>