[PATCH 2/4] ram: stm32mp1: add parameter addr in test FrequencySelectivePattern

Patrice CHOTARD patrice.chotard at st.com
Thu Jul 2 09:35:26 CEST 2020


Hi Patrick

On 6/12/20 10:34 AM, Patrick Delaunay wrote:
> Add a parameter addr in test FrequencySelectivePattern to select
> the base address used to execute the tests.
>
> Default value (when the parameter is absent) is STM32_DDR_BASE,
> selected in get_addr() function.
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> ---
>
>  drivers/ram/stm32mp1/stm32mp1_tests.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/ram/stm32mp1/stm32mp1_tests.c b/drivers/ram/stm32mp1/stm32mp1_tests.c
> index 90e82acda7..fec9fd010e 100644
> --- a/drivers/ram/stm32mp1/stm32mp1_tests.c
> +++ b/drivers/ram/stm32mp1/stm32mp1_tests.c
> @@ -919,10 +919,12 @@ static enum test_result test_freq_pattern(struct stm32mp1_ddrctl *ctl,
>  	enum test_result res = TEST_PASSED, pattern_res;
>  	int i, bus_width;
>  	const u32 **patterns;
> -	u32 bufsize;
> +	u32 bufsize, addr;
>  
>  	if (get_bufsize(string, argc, argv, 0, &bufsize, 4 * 1024, 128))
>  		return TEST_ERROR;
> +	if (get_addr(string, argc, argv, 1, &addr))
> +		return TEST_ERROR;
>  
>  	switch (readl(&ctl->mstr) & DDRCTRL_MSTR_DATA_BUS_WIDTH_MASK) {
>  	case DDRCTRL_MSTR_DATA_BUS_WIDTH_HALF:
> @@ -935,15 +937,14 @@ static enum test_result test_freq_pattern(struct stm32mp1_ddrctl *ctl,
>  	}
>  
>  	printf("running test pattern at 0x%08x length 0x%x width = %d\n",
> -	       STM32_DDR_BASE, bufsize, bus_width);
> +	       addr, bufsize, bus_width);
>  
>  	patterns =
>  		(const u32 **)(bus_width == 16 ? patterns_x16 : patterns_x32);
>  
>  	for (i = 0; i < NB_PATTERN; i++) {
>  		printf("test data pattern %s:", patterns_comments[i]);
> -		pattern_res = test_loop(patterns[i], (u32 *)STM32_DDR_BASE,
> -					bufsize);
> +		pattern_res = test_loop(patterns[i], (u32 *)addr, bufsize);
>  		if (pattern_res != TEST_PASSED)	{
>  			printf("Failed\n");
>  			return pattern_res;
> @@ -1419,9 +1420,9 @@ const struct test_desc test[] = {
>  	 "Verifies r/w and memcopy(burst for pseudo random value.",
>  	 3
>  	},
> -	{test_freq_pattern, "FrequencySelectivePattern", "[size]",
> +	{test_freq_pattern, "FrequencySelectivePattern", "[size] [addr]",
>  	 "write & test patterns: Mostly Zero, Mostly One and F/n",
> -	 1
> +	 2
>  	},
>  	{test_blockseq, "BlockSequential", "[size] [loop] [addr]",
>  	 "test incremental pattern",

Reviewed-by: Patrice Chotard <patrice.chotard at st.com>

Thanks


More information about the U-Boot mailing list