[PATCH] patman: Detect unexpected END

Patrick Delaunay patrick.delaunay at st.com
Thu Jul 2 19:08:24 CEST 2020


Detect unexpected 'END' line when a section is not detected.

This patch detect issue when tag name for section start is misspelled,
for example 'Commit-note:' for 'Commit-notes:'

  Commit-note:
  ....
  END

Then 'Commit-note:' is removed silently by re_remove = "Commit-\w*:"
but 'END' is kept in commit message.

Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
---

 tools/patman/patchstream.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py
index 4fe465e9ab..a575c09b47 100644
--- a/tools/patman/patchstream.py
+++ b/tools/patman/patchstream.py
@@ -260,6 +260,10 @@ class PatchStream:
             else:
                 self.section.append(line)
 
+        # If we are not in a section, it is an unexpected END
+        elif line == 'END':
+                raise ValueError("'END' wihout section")
+
         # Detect the commit subject
         elif not is_blank and self.state == STATE_PATCH_SUBJECT:
             self.commit.subject = line
-- 
2.17.1



More information about the U-Boot mailing list