[PATCH v5 04/14] dtoc: add support to scan drivers

Simon Glass sjg at chromium.org
Sat Jul 4 00:45:45 CEST 2020


Hi Walter,

On Fri, 3 Jul 2020 at 11:45, Walter Lozano <walter.lozano at collabora.com> wrote:
>
> Hi Simon,
>
> On 3/7/20 13:08, Simon Glass wrote:
> > Hi Walter,
> >
> > On Fri, 3 Jul 2020 at 05:07, Walter Lozano <walter.lozano at collabora.com> wrote:
> >> Currently dtoc scans dtbs to convert them to struct platdata and
> >> to generate U_BOOT_DEVICE entries. These entries need to be filled
> >> with the driver name, but at this moment the information used is the
> >> compatible name present in the dtb. This causes that only nodes with
> >> a compatible name that matches a driver name generate a working
> >> entry.
> >>
> >> In order to improve this behaviour, this patch adds to dtoc the
> >> capability of scan drivers source code to generate a list of valid driver
> >> names and aliases. This allows to generate U_BOOT_DEVICE entries using
> >> valid driver names and rise a warning in the case a name is not valid.
> >>
> >> Signed-off-by: Walter Lozano <walter.lozano at collabora.com>
> >> ---
> >>
> >> (no changes since v1)
> >>
> >>   tools/dtoc/dtb_platdata.py            | 91 +++++++++++++++++++++++++--
> >>   tools/dtoc/dtoc_test_driver_alias.dts | 20 ++++++
> >>   tools/dtoc/test_dtoc.py               | 33 ++++++++++
> >>   3 files changed, 140 insertions(+), 4 deletions(-)
> >>   create mode 100644 tools/dtoc/dtoc_test_driver_alias.dts
> >>
> > This seems to do the trick, thanks!
> >
> > But there is one problem remaining - lots of warning output from the
> > various tests:
> >
> > https://pastebin.com/K7GBPiqC
>
> The warnings are removed by the next patch in the series, "[PATCH v4
> 05/14] dtoc: add option to disable warnings", by adding additional
> arguments.
>
> I thought having these two things in different patches made sense, but
> If you prefer I can re send the series with those two patches squashed.
>
> Please confirm.

OK I see. Then that is fine, thanks.

Regards,
SImon


More information about the U-Boot mailing list