[PATCH v4 02/14] dtoc: add missing code comments

Simon Glass sjg at chromium.org
Mon Jul 6 03:31:14 CEST 2020


Hi Walter,

On Fri, 26 Jun 2020 at 07:18, Walter Lozano <walter.lozano at collabora.com> wrote:
>
> Hi Simon,
>
> On 25/6/20 22:42, Simon Glass wrote:
> > On Wed, 24 Jun 2020 at 22:10, Walter Lozano <walter.lozano at collabora.com> wrote:
> >> Add missing information about internal class members in order to make
> >> the code easier to follow.
> >>
> >> Signed-off-by: Walter Lozano <walter.lozano at collabora.com>
> >> ---
> >>
> >>   tools/dtoc/dtb_platdata.py | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > BTW if there was a review tag from last version, please add it to your commit.
>
>
> Thanks for pointing that, I'll take you advice for those commit that
> doesn't change at all. Also thank you for all the time you spent
> reviewing this series and sharing suggestions.

You're welcome. It's a great improvement to of-platdata! You can add
it the tag unless you make a major change to a commit.

Regards,
Simon

Applied to u-boot-dm/next, thanks!


More information about the U-Boot mailing list