Re: [PATCH] pci: rockchip: Mark inline functions as static inline【请注意，邮件由tom.rini at gmail.com代发】

[Kever Yang]

On 2020/7/1 下午11:47, Tom Rini wrote:
> Unless we mark the function as 'static inline' it may end up being
> non-inlined by the compiled and result in duplicate functions.
>
> Cc: Jagan Teki <jagan at amarulasolutions.com>
> Cc: Kever Yang <kever.yang at rock-chips.com>
> Signed-off-by: Tom Rini <trini at konsulko.com>

Reviewed-by: Kever Yang<kever.yang at rock-chips.com>

Thanks,
- Kever

> ---
>   drivers/pci/pcie_rockchip.h | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/pcie_rockchip.h b/drivers/pci/pcie_rockchip.h
> index c3a0a2846d45..845d5059e111 100644
> --- a/drivers/pci/pcie_rockchip.h
> +++ b/drivers/pci/pcie_rockchip.h
> @@ -130,13 +130,12 @@ struct rockchip_pcie {
>   
>   int rockchip_pcie_phy_get(struct udevice *dev);
>   
> -inline struct rockchip_pcie_phy *pcie_get_phy(struct rockchip_pcie *pcie)
> +static inline struct rockchip_pcie_phy *pcie_get_phy(struct rockchip_pcie *pcie)
>   {
>   	return pcie->phy;
>   }
>   
> -inline
> -struct rockchip_pcie_phy_ops *phy_get_ops(struct rockchip_pcie_phy *phy)
> +static inline struct rockchip_pcie_phy_ops *phy_get_ops(struct rockchip_pcie_phy *phy)
>   {
>   	return (struct rockchip_pcie_phy_ops *)phy->ops;
>   }