[PATCH] rtc: pcf2127: fix uninitialized variable msg

Rasmus Villemoes rasmus.villemoes at prevas.dk
Thu Jul 9 13:29:48 CEST 2020


On 09/07/2020 12.58, Biwen Li wrote:
> From: Biwen Li <biwen.li at nxp.com>
> 
> Fix uninitialized variable msg
> 
>  	struct dm_i2c_chip *chip = dev_get_parent_platdata(dev);
> -	struct i2c_msg msg;
> +	struct i2c_msg msg = {0};
>  	int ret;
>  
>  	/* Set the address of the start register to be read */
> 

I assume it's the

        msg.flags |= I2C_M_RD;

line that is warned about (please include such info)? Isn't the right
fix to replace that by

        msg.flags = I2C_M_RD;

?

Rasmus


More information about the U-Boot mailing list