[PATCH v3 1/1] cmd: blkls: Add blkls command

[Heinrich Schuchardt]

On 7/8/20 5:02 AM, Tom Rini wrote:
> On Mon, Mar 30, 2020 at 05:22:58PM +0200, Niel Fourie wrote:
>
>> Add a command to print a list of available block device drivers,
>> and for each, the list of known block devices.
>>
>> Signed-off-by: Niel Fourie <lusus at denx.de>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Stefan Roese <sr at denx.de>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>> Reviewed-by: Stefan Roese <sr at denx.de>
>
> Applied to u-boot/master, thanks!
>

Compiling with CONFIG_CMD_LSB results in a bunch of errors:

cmd/lsblk.c:46:9: error: ‘CMD_RET_SUCCESS’ undeclared (first use in this
function)
  return CMD_RET_SUCCESS;
         ^~~~~~~~~~~~~~~
cmd/lsblk.c: At top level:
cmd/lsblk.c:49:18: error: expected ‘)’ before numeric constant
 U_BOOT_CMD(lsblk, 1, 0, do_lsblk, "list block drivers and devices",
                  ^~
                  )
cmd/lsblk.c:10:12: warning: ‘do_lsblk’ defined but not used
[-Wunused-function]


cmd/lsblk.c: In function ‘do_lsblk’:
cmd/lsblk.c:38:11: warning: implicit declaration of function
‘blk_get_if_type_name’; did you mean ‘dev_get_uclass_name’?
[-Wimplicit-function-declaration]
           blk_get_if_type_name(desc->if_type),
           ^~~~~~~~~~~~~~~~~~~~
           dev_get_uclass_name
cmd/lsblk.c:38:36: error: dereferencing pointer to incomplete type
‘struct blk_desc’
           blk_get_if_type_name(desc->if_type),
                                    ^~
make[1]: *** [scripts/Makefile.build:265: cmd/lsblk.o] Error 1
make: *** [Makefile:1791: cmd] Error 2
make: *** Waiting for unfinished jobs....
  LD      drivers/i2c/built-in.o


Was this ever compiled before merging?

Best regards

Heinrich