[PATCH 07/10] drivers: serial: Make serial_initialize return int

Simon Glass sjg at chromium.org
Fri Jul 10 02:35:18 CEST 2020


On Thu, 9 Jul 2020 at 02:10, Ovidiu Panait <ovidiu.panait at windriver.com> wrote:
>
> serial_initialize is called only during the common init sequence, after
> relocation (in common/board_r.c). Because it has a void return value, it
> has to wrapped in initr_serial. In order to be able to get rid of this
> indirection, make serial_initialize return int.
>
> Remove extern from prototype in order to silence the following checkpatch
> warning:
> check: extern prototypes should be avoided in .h files
>
> Signed-off-by: Ovidiu Panait <ovidiu.panait at windriver.com>
> ---
>
>  drivers/serial/serial-uclass.c | 4 ++--
>  drivers/serial/serial.c        | 4 +++-
>  include/serial.h               | 2 +-
>  3 files changed, 6 insertions(+), 4 deletions(-)
>

Reviewed-by: Simon Glass <sjg at chromium.org>

Has bothered me for a while :-)


More information about the U-Boot mailing list