Using gerrit or github for review?

[Heiko Schocher]

Hello Heinrich,

Am 14.07.2020 um 08:34 schrieb Heinrich Schuchardt:
> On 7/14/20 8:22 AM, Heiko Schocher wrote:
>> Hi Michal,
>>
>> Am 14.07.2020 um 08:09 schrieb Michal Simek:
>>>
>>>
>>> On 13. 07. 20 22:36, Tom Rini wrote:
>>>> On Mon, Jul 13, 2020 at 12:25:42PM -0600, Simon Glass wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> At present U-Boot uses the mailing list for patch review. What do
>>>>> people think about trying out geritt or github for this? I'd be
>>>>> willing to do a trial with the -dm mailing list.
>>>>>
>>>>> My idea is that patman would email out the patches and also upload
>>>>> them to one of these systems. With geritt, emails are sent every time
>>>>> there is a review, but for github I'm not sure.
>>>>
>>>> As you said, you also intended to include gitlab in the list.
>>>>
>>>> So, things that I think could be better, or more widely known, would be
>>>> how to trigger Azure CI runs (as there's good resources available for
>>>> free) and GitLab for non-custodians.  By which I mean, anyone can get a
>>>> CI run on Azure today via a GitHub PR.  Making that known more widely
>>>> would be good.
>>>>
>>>> For patch review, are there any of the Linux kernel bots that are well
>>>> enough documented for someone else to pick up and use?  I feel like our
>>>> biggest problems are:
>>>> - Lack of reviewers in general for various areas.
>>>> - Lack of feedback to users (developers) before being picked up for
>>>>     general changes.
>>>>
>>>> For the second problem, I feel like some of the Linux bots would be a
>>>> little helpful, but probably require some tweaking (figure out when /
>>>> how to fire off more limited CI, or just do a daily CI run vs every
>>>> patch, given the size of our CI build).
>>>>
>>>
>>> Don't have details but patchwork should support (somehow) to run some
>>> checks.
>>> Here you can see it working.
>>> http://patchwork.ozlabs.org/project/devicetree-bindings/patch/1594676120-5862-7-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com/
>>>
>>> or
>>> http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200713132927.24925-2-abailon@baylibre.com/
>>>
>>>
>>> It means when the patch reach patchwork checks can run. Would be
>>> wonderful to get PASS/FAIL with link via email from CI loop.
> 
> The software you need for it is https://github.com/ruscur/snowpatch and
> Jenkins.

Ah, thanks for the tip!

bye,
Heiko
> 
> Best regards
> 
> Heinrich
> 
>>
>> That looks interesting, indeed!
>>
>>> I don't have experience with gerrit but definitely don't like using
>>> github for contribution and prefer to use review based on emails.
>>
>> me too.
>>
>> bye,
>> Heiko
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de