[PATCH 3/4] fs/squashfs: add sources for zlib decompression

Thomas Petazzoni thomas.petazzoni at bootlin.com
Wed Jul 15 21:37:49 CEST 2020


Hello Joao,

On Thu,  9 Jul 2020 19:51:47 +0200
Joao Marcos Costa <joaomarcos.costa at bootlin.com> wrote:

> Add zlib (v1.2.11) functions to U-Boot. SquashFS depends on those
> functions to decompress data from a raw disk image. The actual support
> for zlib into SquashFS sources will be added in a follow-up commit.
> 
> Signed-off-by: Joao Marcos Costa <joaomarcos.costa at bootlin.com>

The header of the commit title is wrong, this commit is not touching
fs/squashfs at all, but lib/zlib.

I think the rest of the commit title are also misleading: I believe
zlib decompression was already supported in U-Boot.

But looking at the code, lib/gunzip.c already has a function called
zunzip(), which seems to do pretty much the same thing: decompress from
a memory buffer into another memory buffer.

Are you sure you cannot use this existing zunzip() function ? zunzip()
is already used by UBIFS.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the U-Boot mailing list