[PATCH 0/3] squashfs fixes

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Jul 16 10:33:51 CEST 2020


On Thu, 16 Jul 2020 09:51:25 +0200
Joao Marcos Costa <joaomarcos.costa at bootlin.com> wrote:

> > As I started reviewing your patch series, I encountered a number of
> > build issues after applying your patches, and building on the latest
> > master. The following patches address the build failures I have
> > encountered. Could you squash them into your commits, so that those
> > fixes are part of your v2 ? Of course, please do some testing, as I
> > have only done build testing so far.  
> 
> Thank you for this series, I was actually working on the v2020.04
> branch, and I think this explains why I was not seeing such errors. 

OK. When you're submitting patches to U-Boot, since the patches will
very likely be applied on master, the patches you send should be based
on master. Otherwise, the maintainer who will apply your patches will
face the sort of problems that I did face.

> > Also, even with those fixes in place, I do still get a worrying gcc
> > warning (from gcc 10):  
> 
> I will update my gcc version, because currently I am using gcc 7.5.

You could also keep gcc 7.x on your system, but simply use a gcc 10.x
toolchain when cross-compiling U-Boot for ARM for example, as I know
you're also testing this on an ARM platform.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the U-Boot mailing list