[PATCH 2/2] fdt_support: skip MTD node with "disabled" in fdt_fixup_mtdparts()

[Masahiro Yamada]

On Fri, Jul 17, 2020 at 12:44 AM Simon Glass <sjg at chromium.org> wrote:
>
> On Wed, 15 Jul 2020 at 04:57, Masahiro Yamada
> <yamada.masahiro at socionext.com> wrote:
> >
> > Currently, fdt_fixup_mtdparts() only checks the compatible property.
> > It is pointless to fix up the disabled node.
> >
> > Skip the node if it has the property:
> >
> >   status = "disabled"
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> > ---
> >
> >  common/fdt_support.c | 17 ++++++++++-------
> >  1 file changed, 10 insertions(+), 7 deletions(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> Are there any tests for this code?

No test code.

It makes more effort since
testing this would need to probe an MTD device
as well as parsing DT.



> I am thinking we should migrate fdt_support to use livetree...

One important thing we should notice is we have
two different DT instances:

[1] DT blob for U-Boot   - used for U-Boot driver model
[2] DT blob for Linux    - passed when booting Linux


In my understanding, the livetree
is supposed to unflatten [1].

fdt_fixup_mtdparts() is obviously fixing [2].


I do not know how livetree would work
for this function.

-- 
Best Regards
Masahiro Yamada