[PATCH v4 4/4] mips: octeon: Add minimal Octeon 3 EBB7304 EVK support

[Stefan Roese]

Hi Daniel,

On 16.07.20 20:54, Daniel Schwierzeck wrote:
>> This patch adds very basic minimal support for the Marvell Octeon 3
>> CN73xx based EBB7304 EVK. Please note that the basic Octeon port does
>> not support DDR3/4 initialization yet. To still use U-Boot on with this
>> port, the L2 cache (4MiB) is used as RAM. This way, U-Boot can boot
>> to the prompt on this board.
>>
>> Supported devices:
>> - UART
>> - reset
>> - CFI parallel NOR flash
>>
>> Signed-off-by: Stefan Roese <sr at denx.de>
>>
>> ---
>>
>> Changes in v4:
>> - Remove CONFIG_BOARD_SIZE_LIMIT
>>
>> Changes in v3:
>> - Remove inclusion of "common.h"
>> - Slightly change some copyright messages (adjust year)
>>
>> Changes in v2:
>> - Removed CONFIG_SYS_MIPS_TIMER_FREQ
>>
>>   arch/mips/dts/Makefile                   |  1 +
>>   arch/mips/dts/mrvl,octeon-ebb7304.dts    | 96 ++++++++++++++++++++++++
>>   arch/mips/mach-octeon/Kconfig            | 14 ++++
>>   board/Marvell/octeon_ebb7304/Kconfig     | 19 +++++
>>   board/Marvell/octeon_ebb7304/MAINTAINERS |  7 ++
>>   board/Marvell/octeon_ebb7304/Makefile    |  8 ++
>>   board/Marvell/octeon_ebb7304/board.c     |  9 +++
>>   configs/octeon_ebb7304_defconfig         | 37 +++++++++
>>   include/configs/octeon_common.h          | 19 +++++
>>   include/configs/octeon_ebb7304.h         | 20 +++++
>>   10 files changed, 230 insertions(+)
>>   create mode 100644 arch/mips/dts/mrvl,octeon-ebb7304.dts
>>   create mode 100644 board/Marvell/octeon_ebb7304/Kconfig
>>   create mode 100644 board/Marvell/octeon_ebb7304/MAINTAINERS
>>   create mode 100644 board/Marvell/octeon_ebb7304/Makefile
>>   create mode 100644 board/Marvell/octeon_ebb7304/board.c
>>   create mode 100644 configs/octeon_ebb7304_defconfig
>>   create mode 100644 include/configs/octeon_common.h
>>   create mode 100644 include/configs/octeon_ebb7304.h
>>
> 
> both Octeon base support series are applied to u-boot-mips/next. I
> reordered and squashed some patches to get a cleaner history. Also
> configs/octeon_ebb7304_defconfig needed a little refresh. The GPIO
> driver needs another update and the SPI driver some more review and
> ack. For the DDR4 init stuff I couldn't spare enough time for review
> yet.
> 
> 
> Could you check if everything still works so that I can prepare the
> pull-request? Thanks.

Thanks Daniel. I checked the "next" branch and all looks good. Running
this on the board also works without any issues. The only thing I
noticed is, that building U-Boot now produces this build warning:

===================== WARNING ======================
This board does not use CONFIG_DM_ETH (Driver Model
for Ethernet drivers). Please update the board to use
CONFIG_DM_ETH before the v2020.07 release. Failure to
update by the deadline may result in board removal.
See doc/driver-model/migration.rst for more info.
====================================================

Feel free to add (squash) this change to the defconfig to remove this
build warning:

diff --git a/configs/octeon_ebb7304_defconfig 
b/configs/octeon_ebb7304_defconfig
index d810b1e45f..204a42b9fd 100644
--- a/configs/octeon_ebb7304_defconfig
+++ b/configs/octeon_ebb7304_defconfig
@@ -29,6 +29,7 @@ CONFIG_CFI_FLASH=y
  CONFIG_SYS_FLASH_USE_BUFFER_WRITE=y
  CONFIG_FLASH_CFI_MTD=y
  CONFIG_SYS_FLASH_CFI=y
+CONFIG_DM_ETH=y
  # CONFIG_NETDEVICES is not set
  CONFIG_DEBUG_UART_SHIFT=3
  CONFIG_DEBUG_UART_ANNOUNCE=y

Or I will send a patch to change it when the patch series is merged into
mainline.

Thanks,
Stefan