[GIT PULL] Pull request: u-boot-imx u-boot-imx-20200716

[Tom Rini]

On Fri, Jul 17, 2020 at 06:05:57PM -0300, Fabio Estevam wrote:

> Hi Tom,
> 
> On Fri, Jul 17, 2020 at 11:55 AM Tom Rini <trini at konsulko.com> wrote:
> 
> > Please note there's a bunch of whitespace errors in
> > drivers/ddr/imx/imx8m/ddrphy_utils.c, a single one in
> > arch/arm/mach-imx/imx8m/soc.c and
> > drivers/pinctrl/nxp/pinctrl-imx*.c has some warnings about using
> > __section(..) vs __attribute__((section(..))) but these are all things
> > that can be addressed with this merged.  So, applied to u-boot/master,
> 
> Could you please share these drivers/pinctrl/nxp/pinctrl-imx*.c warnings?

Sure:
$ ./scripts/checkpatch.pl -q -f drivers/pinctrl/nxp/pinctrl-imx*.c
WARNING: __section(.data) is preferred over __attribute__((section(".data")))
#13: FILE: drivers/pinctrl/nxp/pinctrl-imx5.c:13:
+static struct imx_pinctrl_soc_info imx5_pinctrl_soc_info __attribute__((section(".data")));

total: 0 errors, 1 warnings, 0 checks, 44 lines checked
WARNING: __section(.data) is preferred over __attribute__((section(".data")))
#12: FILE: drivers/pinctrl/nxp/pinctrl-imx7.c:12:
+static struct imx_pinctrl_soc_info imx7_pinctrl_soc_info __attribute__((section(".data")));

total: 0 errors, 1 warnings, 0 checks, 41 lines checked
WARNING: __section(.data) is preferred over __attribute__((section(".data")))
#11: FILE: drivers/pinctrl/nxp/pinctrl-imx8m.c:11:
+static struct imx_pinctrl_soc_info imx8mq_pinctrl_soc_info __attribute__((section(".data")));

total: 0 errors, 1 warnings, 0 checks, 38 lines checked
WARNING: Use the livetree API (dev_read_...)
#59: FILE: drivers/pinctrl/nxp/pinctrl-imx.c:59:
+	if (fdtdec_get_int_array(gd->fdt_blob, node, "fsl,pins",

WARNING: quoted string split across lines
#102: FILE: drivers/pinctrl/nxp/pinctrl-imx.c:102:
+			dev_dbg(dev, "mux_reg 0x%x, conf_reg 0x%x, "
+				"input_reg 0x%x, mux_mode 0x%x, "

WARNING: quoted string split across lines
#103: FILE: drivers/pinctrl/nxp/pinctrl-imx.c:103:
+				"input_reg 0x%x, mux_mode 0x%x, "
+				"input_val 0x%x, config_val 0x%x\n",

WARNING: quoted string split across lines
#172: FILE: drivers/pinctrl/nxp/pinctrl-imx.c:172:
+				dev_dbg(dev, "select_input: offset 0x%x val "
+					"0x%x\n", input_reg, input_val);

WARNING: quoted string split across lines
#187: FILE: drivers/pinctrl/nxp/pinctrl-imx.c:187:
+				dev_dbg(dev, "write config: offset 0x%x val "
+					"0x%x\n", conf_reg, config_val);

WARNING: Use the livetree API (dev_read_...)
#206: FILE: drivers/pinctrl/nxp/pinctrl-imx.c:206:
+	struct fdtdec_phandle_args arg;

WARNING: Use the livetree API (dev_read_...)
#230: FILE: drivers/pinctrl/nxp/pinctrl-imx.c:230:
+	info->mux_mask = fdtdec_get_int(gd->fdt_blob, node, "fsl,mux_mask", 0);

WARNING: Use the livetree API (dev_read_...)
#235: FILE: drivers/pinctrl/nxp/pinctrl-imx.c:235:
+	if (fdtdec_get_bool(gd->fdt_blob, node, "fsl,input-sel")) {

WARNING: Use the livetree API (dev_read_...)
#236: FILE: drivers/pinctrl/nxp/pinctrl-imx.c:236:
+		ret = fdtdec_parse_phandle_with_args(gd->fdt_blob,

WARNING: Use the livetree API (dev_read_...)
#244: FILE: drivers/pinctrl/nxp/pinctrl-imx.c:244:
+		addr = fdtdec_get_addr_size(gd->fdt_blob, arg.node, "reg",

total: 0 errors, 10 warnings, 0 checks, 273 lines checked

> What are the defconfig targets that triggered it?

Not a build-time issue, my scripts do a ./scripts/checkpatch.pl --git
origin/master.. -q and I search on ERROR.  Since the above WARNINGS were
on the same page as the ERRORs I noted them.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200717/5173f5e5/attachment.sig>