[RFC] dfu: remove UPDATE_TFTP

[Michal Simek]

On 21. 07. 20 5:03, Heinrich Schuchardt wrote:
> On 7/15/20 4:48 PM, Michal Simek wrote:
>>
>>
>> On 15. 07. 20 16:42, Heinrich Schuchardt wrote:
>>> On 15.07.20 16:06, Michal Simek wrote:
>>>
>>>
>>>> On 15. 07. 20 15:23, Lukasz Majewski wrote:
>>>>> Hi Heinrich,
>>>>>
>>>>> On 15.07.20 13:24, Lukasz Majewski wrote:
>>>>>>>> Hi Heinrich,
>>>>>>>>
>>>>>>>>> Using UPDATE_TFTP the firmware can be updated from tFTP
>>>>>>>>> by writing to NOR flash. The same is possible by defining
>>>>>>>>> a dfu command in CONFIG_PREBOOT.
>>>>>>>>>
>>>>>>>>> The dfu command cannot only write to NOR but also to
>>>>>>>>> other devices. In README.dfutfp UPDATE_TFTP has been
>>>>>>>>> marked as deprecated.
>>>>>>>>
>>>>>>>> Could you also write in the proper README the steps
>>>>>>>> necessary to have the same functionality as with
>>>>>>>> UPDATE_TFTP with dfu and preboot? I think that it would be
>>>>>>>> good to have it written down in ./doc.
>>>>>>>>
>>>>>
>>>>> doc/README.dfutftp already describes the necessary steps as:
>>>>>
>>>>> * enable CONFIG_DFU_TFTP * enable CONFIG_PREBOOT * put a string
>>>>> like "dfu tftp 0 mmc 0" into the "preboot" env variable
>>>>>
>>>>> Do you want me to explicitly write that "dfu tftp 0 mtd 0"
>>>>> replaces the former auto-update functionality?
>>>
>>>> I am curious if that command is really dfu tftp 0 mtd 0.
>>>
>>> Lukasz was asking about the replacement of the update that was
>>> executed when running with CONFIG_UPDATE_TFTP=y. This function that I
>>> am removing could only write to NOR flash. The update defined via
>>> CONFIG_PREBOOT is much more flexible and can server other storage media.
>>
>> I have really not a problem with removing it.
>>
>>>
>>> The different accessible devices are described in doc/README.dfu.
>>> "ram" is one of them.
>>
>> yes and link to README.dfutftp where only one options is listed
>> as "dfu tftp 0 mmc 0" which is definitely only one option which you can
>> use. Would be really good to list that options there and also retest them.
> 
> We will be able to have automated tests writing to the DFU "ram" and DFU
> "mtd" driver once the flash driver used by QEMU works properly. See
> 
> https://lists.denx.de/pipermail/u-boot/2020-July/420835.html
> mtd: cfi_flash: read device tree correctly

Do you plan to wire it with test/py framework and run it via travis/gitlab?

Thanks,
Michal