[PATCH v4 00/27] rockchip: x86: Support building ROM files automatically with binman

[Simon Glass]

Hi Kever (and other Rockchip people),

Are there any more comments on this series? I can pick it up via -dm
but I would like to get more comments if possible. I'd also like to
see if someone can take on removing the other ad-hoc Rockchip script.

Regards,
Simon


On Sun, 19 Jul 2020 at 21:07, Simon Glass <sjg at chromium.org> wrote:
>
> Hi Bin,
>
> On Sun, 19 Jul 2020 at 19:12, Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > Hi Simon,
> >
> > On Mon, Jul 20, 2020 at 3:56 AM Simon Glass <sjg at chromium.org> wrote:
> > >
> > > Rockchip-based Chromebooks support booting from SPI flash. It is annoying
> > > to have to manually build the SPI image when the SD image is built
> > > automatically.
> > >
> > > This feature is already available for x86 devices, so the existing
> > > mechanism is reused. Briefly, this allows a BUILD_ROM environment variable
> > > to be provided to indicate that any required binary blobs are present and
> > > it is safe to build the ROM.
> > >
> > > A new 'mkimage' type is added to binman to support building binaries
> > > containing mkimagem using a binman definition to configure it. This avoids
> > > Makefile/shell/Python code to do the same thing.
> > >
> > > This series also migrates some rockchip boards to use binman to produce
> > > their FIT as well, resulting in removing the fit_spl_optee.sh script.
> > >
> > > Other archs and the rest of rockchip could be migrated too.
> > >
> > > This series uses binman to produce a ROM image on two selected
> > > Chromebooks, Bob (RK3399) and Jerry (RK3388).
> > >
> > > Changes in v4:
> > > - Add a new CONFIG_ROCKCHIP_SPI_IMAGE to control SPI-image generation
> > > - Use CONFIG_ROCKCHIP_SPI_IMAGE to select the image
> > > - Update for changes to arch/arm/mach-k3/config.mk
> > > - Move the .itb output to a separate rockchip-optee.dtsi file
> > > - Add a check for CONFIG_FIT before building the .its
> > >
> > > Changes in v3:
> > > - Add a comment about CONFIG_SPL_FRAMEWORK
> > > - Drop rockchip changes which should not be in this patch
> > > - Move in the rockchip changes mistakenly in the earlier x86 patch
> > > - Drop use of rk322x.dtsi
> > > - Add changes to rk3288-u-boot.dtsi instead
> > > - Drop leftover debugging
> >
> > It looks you have applied part of the v3 in u-boot-dm, and sent the
> > remaining patches as v4?
> >
> > I re-assigned this series to you in patchwork.
>
> Yes I applied the binman patches and those that were reviewed.
>
> I am not sure if this shold be an x86 or rockchip series, or perhaps
> we just wait until people have had a look.
>
> Regards,
> Simon