[Uboot-stm32] [PATCH] board: update test on misc_read result in board_late_init
Patrice CHOTARD
patrice.chotard at st.com
Tue Jul 28 15:27:25 CEST 2020
On 7/3/20 5:45 PM, Patrick Delaunay wrote:
> Update management of misc_read, which now return length of data
> after the commit 8729b1ae2cbd ("misc: Update read() and write()
> methods to return bytes xfered")
>
> Fixes: 8b8b3d6b55b9 ("stm32mp1: board: add environment variable for board id and board rev")
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
> ---
>
> board/st/stm32mp1/stm32mp1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
> index 4553329b25..b51165a636 100644
> --- a/board/st/stm32mp1/stm32mp1.c
> +++ b/board/st/stm32mp1/stm32mp1.c
> @@ -732,7 +732,7 @@ int board_late_init(void)
> if (!ret)
> ret = misc_read(dev, STM32_BSEC_SHADOW(BSEC_OTP_BOARD),
> &otp, sizeof(otp));
> - if (!ret && otp) {
> + if (ret > 0 && otp) {
> snprintf(buf, sizeof(buf), "0x%04x", otp >> 16);
> env_set("board_id", buf);
>
Reviewed-by: Patrice Chotard <patrice.chotard at st.com>
Thanks
Patrice
More information about the U-Boot
mailing list