[PATCH v1 13/24] arm: octeontx: Add headers for OcteonTX

[Simon Glass]

Hi Stefan,

On Fri, 24 Jul 2020 at 04:09, Stefan Roese <sr at denx.de> wrote:
>
> From: Suneel Garapati <sgarapati at marvell.com>
>
> Signed-off-by: Suneel Garapati <sgarapati at marvell.com>
>
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
>
> Changes in v1:
> - Change patch subject
>
>  arch/arm/include/asm/arch-octeontx/board.h    |  123 ++
>  arch/arm/include/asm/arch-octeontx/clock.h    |   25 +
>  .../asm/arch-octeontx/csrs/csrs-mio_emm.h     | 1193 +++++++++++++++++
>  .../include/asm/arch-octeontx/csrs/csrs-xcv.h |  428 ++++++
>  arch/arm/include/asm/arch-octeontx/gpio.h     |    6 +
>  arch/arm/include/asm/arch-octeontx/smc.h      |   20 +
>  arch/arm/include/asm/arch-octeontx/soc.h      |   33 +
>  7 files changed, 1828 insertions(+)
>  create mode 100644 arch/arm/include/asm/arch-octeontx/board.h
>  create mode 100644 arch/arm/include/asm/arch-octeontx/clock.h
>  create mode 100644 arch/arm/include/asm/arch-octeontx/csrs/csrs-mio_emm.h
>  create mode 100644 arch/arm/include/asm/arch-octeontx/csrs/csrs-xcv.h
>  create mode 100644 arch/arm/include/asm/arch-octeontx/gpio.h
>  create mode 100644 arch/arm/include/asm/arch-octeontx/smc.h
>  create mode 100644 arch/arm/include/asm/arch-octeontx/soc.h

Reviewed-by: Simon Glass <sjg at chromium.org>

Generic thoughts to consider:
- drop extra brackets around constants - e.g. MIO_EMM_BAR_E_MIO_EMM_PF_BAR4
- use #define or enum instead of inline functions, e.g. MIO_EMM_DMA
- lower-case hex

I don't normally see bitfields in U-Boot. Is that a good idea?

Regards,
Simon