[PATCH v3 3/5] include/u-boot, lib/zlib: add sources for zlib decompression

[Tom Rini]

On Wed, Jul 29, 2020 at 06:00:57PM +0200, Joao Marcos Costa wrote:
> On Wed, 29 Jul 2020 11:27:45 -0400
> Tom Rini <trini at konsulko.com> wrote:
> 
> > On Tue, Jul 21, 2020 at 11:22:57AM +0200, Joao Marcos Costa wrote:
> > 
> > > Add zlib (v1.2.11) uncompr() function to U-Boot. SquashFS depends on
> > > this function to decompress data from a raw disk image. The actual
> > > support for zlib into SquashFS sources will be added in a follow-up
> > > commit.
> > > 
> > > Signed-off-by: Joao Marcos Costa <joaomarcos.costa at bootlin.com>
> > > ---
> > > Changes in v3:
> > > 	- No changes since v2.
> > > Changes in v2:
> > > 	- Changed commit title and message, which were wrong and/or
> > > misleading in v1.
> > >  include/u-boot/zlib.h | 32 ++++++++++++++
> > >  lib/zlib/uncompr.c    | 97
> > > +++++++++++++++++++++++++++++++++++++++++++ lib/zlib/zlib.c
> > > |  1 + 3 files changed, 130 insertions(+)
> > >  create mode 100644 lib/zlib/uncompr.c  
> > 
> > Can you confirm that on a platform where we aren't enabling squashfs
> > the new zlib functionality ends up being discarded at link time?
> > Thanks!
> > 
> 
> I dumped lib/zlib/zlib.o with readelf and the new functionality is not
> discarded, even though the SquashFS support is not enabled, but this
> issue will be fixed in the next version (v4). Thank you!

Well, don't dump lib/zlib/zlib.o, that won't say.  Check u-boot.map :)


-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200729/b7e9d8a4/attachment.sig>