[PATCH v3 1/1] phy: add support for stingray PAXB PHY controller

Rayagonda Kokatanur rayagonda.kokatanur at broadcom.com
Thu Jul 30 05:58:29 CEST 2020


Hi Tom,

On Sat, Jun 27, 2020 at 1:31 AM Tom Rini <trini at konsulko.com> wrote:
>
> On Thu, Jun 25, 2020 at 10:57:09PM +0530, Rayagonda Kokatanur wrote:
> > Hi Tom,
> >
> >
> > On Sun, Apr 12, 2020 at 8:46 PM Rayagonda Kokatanur
> > <rayagonda.kokatanur at broadcom.com> wrote:
> > >
> > > On Thu, Apr 9, 2020 at 7:11 PM Tom Rini <trini at konsulko.com> wrote:
> > > >
> > > > On Thu, Apr 02, 2020 at 04:08:12PM +0530, Rayagonda Kokatanur wrote:
> > > >
> > > > > From: Srinath Mannam <srinath.mannam at broadcom.com>
> > > > >
> > > > > Add support for stingray PAXB PHY controller driver.
> > > > > This driver supports maximum 8 PAXB phys using pipemux data.
> > > > >
> > > > > Signed-off-by: Srinath Mannam <srinath.mannam at broadcom.com>
> > > > > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur at broadcom.com>
> > > > > Reviewed-by: Stefan Roese <sr at denx.de>
> > > > > ---
> > > > > Changes from v2:
> > > > >  -Address review comments from Stefan Roese,
> > > > >   Rearrange the include files.
> > > > >   Remove dm/device.h as its included part of dm.h.
> > > > >
> > > > > Changes from v1:
> > > > >  -Address review comments from Stefan Roese,
> > > > >   Use GENMASK() instead of hard code value.
> > > > >   Remove unwanted struct declaration.
> > > > >   Get pr_err() into single line.
> > > > >
> > > > >  drivers/phy/Kconfig           |   7 ++
> > > > >  drivers/phy/Makefile          |   1 +
> > > > >  drivers/phy/phy-bcm-sr-pcie.c | 177 ++++++++++++++++++++++++++++++++++
> > > >
> > > > The patch itself is fine but I think shows another problem.  Can you
> > > > please add a patch that lists something relevant in the top-level
> > > > MAINTAINERS file and list this and all of the other drivers, etc, that
> > > > wouldn't just be listed in the board MAINATINERS file?  Thanks!
> >
> > I have a plan to update the top level MAINTAINER file with all new
> > driver and board files in a separate patch.
> > Hope this is fine, please let me know.
>
> OK, thanks.  I'll be picking up more patches again soon for -next.

Could you please pick this patch.
If any further review comments, please let me know.

Best regards,
Rayagonda

>
> --
> Tom


More information about the U-Boot mailing list