[PATCH v3 3/5] include/u-boot, lib/zlib: add sources for zlib decompression

[Joao Marcos Costa]

On Thu, 30 Jul 2020 08:17:59 -0400
Tom Rini <trini at konsulko.com> wrote:

> On Thu, Jul 30, 2020 at 02:10:03PM +0200, Joao Marcos Costa wrote:
> > On Wed, 29 Jul 2020 12:54:23 -0400
> > Tom Rini <trini at konsulko.com> wrote:
> >   
> > > On Wed, Jul 29, 2020 at 06:00:57PM +0200, Joao Marcos Costa
> > > wrote:  
> > > > On Wed, 29 Jul 2020 11:27:45 -0400
> > > > Tom Rini <trini at konsulko.com> wrote:
> > > >     
> > > > > On Tue, Jul 21, 2020 at 11:22:57AM +0200, Joao Marcos Costa
> > > > > wrote: 
> > > > > > Add zlib (v1.2.11) uncompr() function to U-Boot. SquashFS
> > > > > > depends on this function to decompress data from a raw disk
> > > > > > image. The actual support for zlib into SquashFS sources
> > > > > > will be added in a follow-up commit.
> > > > > > 
> > > > > > Signed-off-by: Joao Marcos Costa
> > > > > > <joaomarcos.costa at bootlin.com> ---
> > > > > > Changes in v3:
> > > > > > 	- No changes since v2.
> > > > > > Changes in v2:
> > > > > > 	- Changed commit title and message, which were wrong
> > > > > > and/or misleading in v1.
> > > > > >  include/u-boot/zlib.h | 32 ++++++++++++++
> > > > > >  lib/zlib/uncompr.c    | 97
> > > > > > +++++++++++++++++++++++++++++++++++++++++++ lib/zlib/zlib.c
> > > > > > |  1 + 3 files changed, 130 insertions(+)
> > > > > >  create mode 100644 lib/zlib/uncompr.c      
> > > > > 
> > > > > Can you confirm that on a platform where we aren't enabling
> > > > > squashfs the new zlib functionality ends up being discarded at
> > > > > link time? Thanks!
> > > > >     
> > > > 
> > > > I dumped lib/zlib/zlib.o with readelf and the new functionality
> > > > is not discarded, even though the SquashFS support is not
> > > > enabled, but this issue will be fixed in the next version (v4).
> > > > Thank you!    
> > > 
> > > Well, don't dump lib/zlib/zlib.o, that won't say.  Check
> > > u-boot.map :) 
> > 
> > Thanks for the tip! Now I can confirm that the functionality is
> > discarded when squashfs is not enabled. I just would like to know
> > if I should send the tests in the same patch as the SquashFS
> > commands, or should it be into a separate patch?  
> 
> A separate patch, and are you able to run them on sandbox then?  So it
> should also enable squashfs on that target.  Thanks!
> 

This will be addressed in v4. Thanks!