[PATCH v3] dm: uclass: don't assign aliased seq numbers
sjg at chromium.org
Tue Mar 3 03:39:35 CET 2020
On Wed, 5 Feb 2020 at 13:05, Simon Glass <sjg at chromium.org> wrote:
> On Mon, 3 Feb 2020 at 10:12, Michael Walle <michael at walle.cc> wrote:
> > If there are aliases for an uclass, set the base for the "dynamically"
> > allocated numbers next to the highest alias.
> > Please note, that this might lead to holes in the sequences, depending
> > on the device tree. For example if there is only an alias "ethernet1",
> > the next device seq number would be 2.
> > In particular this fixes a problem with boards which are using ethernet
> > aliases but also might have network add-in cards like the E1000. If the
> > board is started with the add-in card and depending on the order of the
> > drivers, the E1000 might occupy the first ethernet device and mess up
> > all the hardware addresses, because the devices are now shifted by one.
> > Also adapt the test cases to the new handling and add test cases
> > checking the holes in the seq numbers.
> > Signed-off-by: Michael Walle <michael at walle.cc>
> > Reviewed-by: Alex Marginean <alexandru.marginean at nxp.com>
> > Tested-by: Alex Marginean <alexandru.marginean at nxp.com>
> > Acked-by: Vladimir Oltean <olteanv at gmail.com>
> > ---
> Reviewed-by: Simon Glass <sjg at chromium.org>
> (added Joe for review fo network parts)
Unfortunately this breaks some ARM and PPC boards:
I've dropped it for now. Please can you take a look?
More information about the U-Boot