[PATCH v2 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

[Jonas Smedegaard]

Hi Andre,

Quoting Andre Przywara (2020-03-02 10:51:08)
> On Sat, 29 Feb 2020 16:58:55 +0100
> Jonas Smedegaard <dr at jones.dk> wrote:
> 
> Hi Jonas,
> 
> > commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to
> > Kconfig") intended to support CONFIG_PREBOOT, but
> > include/configs/sunxi-common.h hardcodes preboot as part of internally
> > defined CONSOLE_STDIN_SETTINGS, silently ignoring any board-specific
> > CONFIG_PREBOOT.
> > 
> > Simply moving CONFIG_PREBOOT to Kconfig does not work here,
> > as that would loose the logic of implicitly setting a conditional default.
> 
> Can't we do this in arch/arm/mach-sunxi/Kconfig directly:
> config PREBOOT
>         default "usb start" if USB_KEYBOARD

Ahh, of course.  Thanks!

I guess that's also what Lukasz was getting at, now that I reread his 
comment for v1.

I'll (test and most likely) make a v3 with your proposed change.

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200303/3d717c90/attachment.sig>