[PATCH v3 1/2] sunxi: fix support board-specific CONFIG_PREBOOT
Jonas Smedegaard
dr at jones.dk
Wed Mar 4 12:15:43 CET 2020
Quoting Andre Przywara (2020-03-04 11:59:40)
> On Tue, 3 Mar 2020 16:08:00 +0100
> Jonas Smedegaard <dr at jones.dk> wrote:
> > Tested-by: Jonas Smedegaard <dr at jones.dk>
>
> Some nit: This is somewhat implicit when you are the author. At least that's the hope ;-)
Ah, ok. Will keep that in mind for future patch proposals.
> > Signed-off-by: Jonas Smedegaard <dr at jones.dk>
>
> Reviewed-by: Andre Przywara <andre.przywara at arm.com>
Thanks!
> > Series-Cc: Jagan Teki <jagan at amarulasolutions.com>
> > Series-Cc: Lukasz Majewski <lukma at denx.de>
> > Series-Cc: Andre Przywara <andre.przywara at arm.com>
>
> Is this because of patman? If this applies to the whole series, I
> typically just add CC:s to the git send-email command line. that keeps
> the commits cleaner. I am wondering if this tag should be added to the
> cover letter then, because patman requires those tags only in one
> commit of a series.
You mean you just memorize relevant Cc addresses and add them manually?
I am new to patman and to contributing patches like this, and just
fumbled my way to something that seemed to work. I shall try adopt your
described approach for future patch proposals, thanks!
- Jonas
--
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200304/72cc95a4/attachment.sig>
More information about the U-Boot
mailing list