sjg at chromium.org
Thu Mar 5 00:11:22 CET 2020
On Mon, 2 Mar 2020 at 13:01, Rasmus Villemoes
<rasmus.villemoes at prevas.dk> wrote:
> On 02/03/2020 20.47, Simon Glass wrote:
> > Hi Rasmus,
> > On Fri, 28 Feb 2020 at 16:09, Rasmus Villemoes
> > <rasmus.villemoes at prevas.dk> wrote:
> >> Now that particular one seems a bit fishy: Why is it ok to cache the
> >> location of the BLOBLISTT_SPL_HANDOFF blob in gd->spl_handoff? Later in
> >> the init sequence there's a call to reserve_bloblist, and later again
> >> reloc_bloblist. Doesn't that leave gd->spl_handoff stale?
> > Yes it does. It is only supposed to be used in the early stages of
> > U-Boot (proper) init.
> Yes, that's what I thought - and if it's only actually used once or
> twice during the early stages, there's not much point in caching it.
> > Actually I think that member could be dropped and we could search for
> > it each time:
> > ./arch/x86/cpu/broadwell/cpu_from_spl.c
> Yes, there didn't seem to be many users, so it should not be that hard
> to get rid of. I also think that sets a better precedent for future
> bloblist users.
Sounds good, thanks.
I wonder if one day we will want to support multiple bloblists in
different memory locations.
More information about the U-Boot