[PATCH v3 4/4] board_f.c: Insure 16 alignment of start_addr_sp and reserved memory

Stephen Warren swarren at wwwdotorg.org
Fri Mar 6 20:13:45 CET 2020


On 3/6/20 11:17 AM, Patrick Delaunay wrote:
> Add a function reserve_stack_aligned() to reserved memory with 16 bits
> alignment after the stack pointer (gd->start_addr_sp) and use this new
> function in board_f.c to reserve all the memory area (malloc, board, gd,
> fdt, bootstage, stacks).
> 
> This 16 byte alignment is needed for cast on struct pointer
> for the reserved memory, for example:
> + x86_64 ABI: https://reviews.llvm.org/D30049: 16 bytes
> + ARMv8 Instruction Set Overview: quad word, 16 bytes
> 
> An other alignment value could be needed for other architecture.

I think the series look OK, so,
Acked-by: Stephen Warren <swarren at nvidia.com>


Nit: Ensure not insure, in a number of places.


More information about the U-Boot mailing list