[PATCH v2 08/39] x86: Correct wording of coreboot source code

Simon Glass sjg at chromium.org
Wed Mar 11 00:22:47 CET 2020


Hi Andy,

On Mon, 9 Mar 2020 at 01:44, Andy Shevchenko <andy.shevchenko at gmail.com> wrote:
>
> On Mon, Mar 9, 2020 at 5:47 AM Simon Glass <sjg at chromium.org> wrote:
> >
> > Some files are taken or modified from coreboot, but the files are
> > no-longer part of the coreboot project. Fix the wording in a few places.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> > ---
> >
> > Changes in v2: None
> >
> >  arch/x86/cpu/coreboot/timestamp.c              | 4 ++--
> >  arch/x86/include/asm/arch-coreboot/timestamp.h | 4 ++--
> >  arch/x86/include/asm/intel_pinctrl_defs.h      | 2 --
> >  3 files changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/x86/cpu/coreboot/timestamp.c b/arch/x86/cpu/coreboot/timestamp.c
> > index e698200d70..e8ccaf2212 100644
> > --- a/arch/x86/cpu/coreboot/timestamp.c
> > +++ b/arch/x86/cpu/coreboot/timestamp.c
> > @@ -1,8 +1,8 @@
> >  // SPDX-License-Identifier: GPL-2.0+
> >  /*
> > - * This file is part of the coreboot project.
> > - *
> >   * Copyright (C) 2011 The ChromiumOS Authors.  All rights reserved.
> > + *
> > + * Modified from the coreboot version
>
> Perhaps leave the period at the end of the line to follow English punctuation?

This is actually something I try to avoid. It is not a sentence and
turning it into one by adding more words doesn't improve its value
IMO.

Regards,
Simon


More information about the U-Boot mailing list