[PATCH 07/20] gitlab: Use the --board buildman flag

Simon Glass sjg at chromium.org
Wed Mar 11 00:22:57 CET 2020


Hi Tom,

On Mon, 9 Mar 2020 at 11:46, Tom Rini <trini at konsulko.com> wrote:
>
> On Fri, Mar 06, 2020 at 08:07:21PM -0700, Simon Glass wrote:
>
> > The current method of selecting the board to build is a bit error-prone,
> > e.g. with "^sandbox$" it actually builds 5 boards (all of those in the
> > sandbox architecture).
>
> OK, hold up.  You've reminded me of something that's been broken for a
> while and I forgot to follow up on.  Which is that at some point we
> stopped applying regex to either only the defconfig name, or stopped
> checking that as the first one.  The example in question used to only
> build sandbox_defconfig, but now (and for some time) has built all of
> arch or soc sandbox.

Are you sure we even used just the defconfig name? I don't recall
that. Do you know when this was?

Since 'sandbox' is an arch name this will build anything sandbox
board, and I think that is intended.

>
> That said, I'm not sure that at the end of the day I'm opposed to the
> --board flag instead.

OK.

Regards,
Simon


More information about the U-Boot mailing list