[PATCH v2] Makefile: doesn't need check stack size when dtb is not built

AKASHI Takahiro takahiro.akashi at linaro.org
Wed Mar 11 01:01:17 CET 2020


Tom,

On Tue, Mar 10, 2020 at 09:56:42AM -0600, Stephen Warren wrote:
> On 3/9/20 6:20 PM, AKASHI Takahiro wrote:
> > The commit 5fed97af20da ("Makefile: ensure DTB doesn't overflow into
> > initial stack") adds an extra check for stack size in BSS if
> > CONFIG_SYS_INIT_SP_BSS_OFFSET is enabled.
> > This check, however, doesn't make sense under the configuration where
> > control dtb won't be built in and it should be void in such cases.
> > 
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi at linaro.org>
> > Fixes: 5fed97af20da ("Makefile: ensure DTB doesn't overflow into
> > 	initial stack")
> 
> It would be best if that line wasn't wrapped; that will make it easier for
> anyone searching for the commit description, since they won't have to know
> to search for a substring of the the description instead of the whole thing.

Can you make this change for me when you merge this patch, please?

> Reviewed-by: Stephen Warren <swarren at nvidia.com>

Thanks,
-Takahiro Akashi


More information about the U-Boot mailing list