[PATCH v2 09/39] x86: apl: Move p2sb ofdata reading to the correct method

[Andy Shevchenko]

On Wed, Mar 11, 2020 at 06:17:32AM -0600, Simon Glass wrote:
> On Tue, 10 Mar 2020 at 08:39, Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
> > On Sun, Mar 08, 2020 at 09:44:33PM -0600, Simon Glass wrote:

> > >               if (plat->bdf < 0)
> > >                       return log_msg_ret("Cannot get p2sb PCI address",
> > > -                                        plat->bdf);
> > > +                                             plat->bdf);
> >
> > Not sure I understand this hunk WRT the patch itself.
> 
> This is to fix a checkpatch error - it reports problems in nearby lines.

So, checkpatch insist on wrong indentation?!

> > > +     if (spl_phase() == PHASE_TPL)
> > >               return p2sb_early_init(dev);
> >
> > > +     else if (spl_phase() == PHASE_SPL)
> >
> > Redundant 'else', but I think we already discussed that and you prefer this
> > way. However, I think this is waste of compilation time. In any case, matter
> > of taste.
> 
> Yes. I feel that it shows that there are two options.
> 
> Just for fun I wrote a program to try to benchmark the difference and
> it does not seem to be detectable.

Compiler optimizes it away in any case, so, you won't see any difference.

> > > +             return p2sb_spl_init(dev);

-- 
With Best Regards,
Andy Shevchenko