[PATCH v3 0/7] x86: Improve support for chain-loading U-Boot

Andy Shevchenko andy.shevchenko at gmail.com
Wed Mar 11 16:22:52 CET 2020


On Wed, Mar 11, 2020 at 4:54 PM Igor Opaniuk <igor.opaniuk at gmail.com> wrote:
> On Wed, Mar 11, 2020 at 3:04 PM Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
> > On Wed, Mar 11, 2020 at 06:24:07AM -0600, Simon Glass wrote:
> > > On Wed, 11 Mar 2020 at 06:09, Andy Shevchenko
> > > <andriy.shevchenko at linux.intel.com> wrote:
> > > > On Tue, Mar 10, 2020 at 08:28:29PM -0600, Simon Glass wrote:
> > > > > On Tue, 10 Mar 2020 at 08:51, Andy Shevchenko
> > > > > <andriy.shevchenko at linux.intel.com> wrote:
> > > > > > On Sat, Mar 07, 2020 at 04:22:13PM -0700, Simon Glass wrote:
> >
> > ...
> >
> > > > > It looks like it went to the mailing list...
> > > >
> > > > > are you subscribed?
> > > >
> > > > It doesn't matter if you want people to pay an attention (by putting them to Cc
> > > > list), so, since it was one patch I can't see the rest and know if they affect
> > > > or not the one, you Cc'ed me to.
> > >
> > > I don't fully understand this, but are you saying you did not get the
> > > patches in your email? If you subscribe to the U-Boot mailing list you
> > > should receive all patches even if not cc'd to you.
> >
> > Probably I got to another email, not this one.
> >
> > > I did not specifically cc you on this series but I can do that if I
> > > send it again. But patman has added you to one patch (number 3) and
> > > therefore you are also cc'd on the cover letter.
> >
> > Yes, and this one I got without seeing full picture.
> >
> > > Can you check whether you are subscribed to the mailing list?
> >
> > As I said, I am not subscribed by email patman uses to Cc me.
> >
> >
> > Basically it's a bug in patman. Either it shouldn't tell me, or should Cc to
> > the entire series. Of course there are cases, when patches are independent and
> > no need to spam everybody with tons of emails, but this should be clarified in
> > cover letter. Did I miss that?
>
> AFAIR, last time you were not happy about "irrelevant" patches that were CC-ed
> to you "by mistake" [1]. This time, as I see, is vice-versa.

Nope, it's not. It maybe that I missed cover letter to tell that the
rest is irrelevant to me. Otherwise Cc list is not filled correctly.

> The algo is simple - if the change touches a file where you're marked as one
> of commiters/maintainers - it will add your email to CC, otherwise it won't
> (however you can still find the full list of patches in the ML, it takes
> a couple of seconds only).

Yes, but here is obvious flaw. If the change is done in the file
dependent to the preparatory patch(es), then I need to be Cc'ed in all
relevant.

For example, patch 1 does introduce nice helper function foo(),
patches 2-(N-1) does change some irrelevant files, patch N touches my
stuff, I have to be Cc'ed to the 1) cover letter, 2) patch 1, 3) patch
N.

> Unfortunately current state of tooling in U-Boot is not too good to be able
> to read thoughts of people and guess their wishes.

See above. *Algo is simple*.

> But if you know how to improve that, patches are always welcome!
>
> [1] https://patchwork.ozlabs.org/cover/1225901/



-- 
With Best Regards,
Andy Shevchenko


More information about the U-Boot mailing list