[PATCH v5 06/11] serial: actions: add uart support for s700

Andre Przywara andre.przywara at arm.com
Thu Mar 12 12:39:08 CET 2020


On Wed, 11 Mar 2020 23:34:16 +0530
Amit Singh Tomar <amittomer25 at gmail.com> wrote:

> UART controller present on S700 is compatible with existing
> S900 controller, this patch simply adds a proper compatible string
> so that owl uart driver can be reused for S700.

Please move this patch before the s900.dtsi update, and keep *both* strings in for now. Otherwise the Bubblegum board breaks with the .dtsi update.

You can remove the undocumented actions,s900-serial string with the .dtsi update patch then.

And please change the subject, as this is not S700 related, but actually fixes a wrong compatible name.

Cheers,
Andre
 
> Reviewed-by: Andre Przywara <andre.przywara at arm.com>
> Signed-off-by: Amit Singh Tomar <amittomer25 at gmail.com>
> ---
> Changes since v4:
>         * Moved it to from 09/11 to 06/11.
> Changes since v3:
>         * Used only owl-uart for compatible string.
> Changes since v2:
>         * No changes.   
> Changes since v1:
>         * No changes.
> ---
>  drivers/serial/serial_owl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/serial/serial_owl.c b/drivers/serial/serial_owl.c
> index 7ead73e..b76cf89 100644
> --- a/drivers/serial/serial_owl.c
> +++ b/drivers/serial/serial_owl.c
> @@ -120,7 +120,7 @@ static const struct dm_serial_ops owl_serial_ops = {
>  };
>  
>  static const struct udevice_id owl_serial_ids[] = {
> -	{ .compatible =	"actions,s900-serial" },
> +	{ .compatible =	"actions,owl-uart" },
>  	{ }
>  };
>  



More information about the U-Boot mailing list