[PATCH] mkimage: fit_image: Make fit header and data align to 512

[Tom Rini]

On Fri, Mar 13, 2020 at 02:09:32PM +0100, Rasmus Villemoes wrote:
> On 13/03/2020 03.07, Heinrich Schuchardt wrote:
> > Am March 13, 2020 1:50:41 AM UTC schrieb Kever Yang <kever.yang at rock-chips.com>:
> >> The image is usually stored in block device like emmc, SD card, make
> >> the
> >> offset of image data aligned to block(512 byte) can avoid data copy
> >> during boot process.
> >> eg. SPL boot from FIT image with external data:
> >> - SPL read the first block of FIT image, and then parse the header;
> >> - SPL read image data separately;
> >> - The first image offset is the base_offset which is the header size;
> >> - The second image offset is just after the first image;
> >> - If the offset of imge does not aligned, SPL will do memcpy;
> >> The header size is a ramdon number, which is very possible not aligned,
> >> so
> >> add align for FIT header and image data for better performance.
> 
> Why not let -B take an integer argument, so the same flag can be used
> the day someone needs stuff to be aligned on a 4096 byte boundary?

Agreed, I'm not happy with the 512 byte assumption either.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200313/7568431a/attachment.sig>