[PATCH 0/3] watchdog: honour hw_margin_ms property

Stefan Roese sr at denx.de
Sat Mar 14 13:04:53 CET 2020

On 13.03.20 17:04, Rasmus Villemoes wrote:
> Some watchdogs must be reset more often than the once-per-second
> ratelimit used by the generic watchdog_reset function in
> wdt-uclass.c. There's precedent (from the gpio-wdt driver in linux)
> for using a property called hw_margin_ms to let the device tree tell
> the driver how often the device needs resetting. So use that
> generically. No change in default behaviour.
> On top of https://patchwork.ozlabs.org/patch/1242772/ .
> Stefan, something like this?

Yes, thanks for looking into this.

> That at least solves half my problems and
> might be useful to others as well. Then I'll have to figure out the
> time-stands-still problem in some other way.

If its too hard to enable interrupts in SPL for you or to provide some
other means of a working get_timer() API, then we needto find another
solution. You started with this weak function, which of course works.
What other options are there? Adding a callback mechanism to register
platform specific callback functions? Even though this might get a
little bit too complicated.


More information about the U-Boot mailing list