[PATCH 084/108] x86: acpi: Support generation of the DBG2 table

[Simon Glass]

Hi Leif,

On Mon, 27 Jan 2020 at 05:34, Leif Lindholm <leif at nuviainc.com> wrote:
>
> Hi Simon,
>
> A portion of this set is very much not x86-specific. (more below)
>
> On Sun, Jan 26, 2020 at 22:06:31 -0700, Simon Glass wrote:
> > Add an implementation of the DBG2 (Debug Port Table 2) ACPI table.
> > Adjust one of the header includes to be in the correct order, before
> > adding more.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> >  arch/x86/lib/acpi_table.c | 112 +++++++++++++++++++++++++++++++++++++-
> >  include/acpi_table.h      |  31 +++++++++++
> >  2 files changed, 142 insertions(+), 1 deletion(-)
> >

[..]

> > +void acpi_create_dbg2(struct acpi_dbg2_header *dbg2,
> > +                   int port_type, int port_subtype,
> > +                   struct acpi_gen_regaddr *address, u32 address_size,
> > +                   const char *device_path)
>
> But this one would be usable by any of the architectures supported by
> ACPI. Could the acpi_create_* functions be moved somewhere
> non-arch-specific, like a new lib/acpi?
>
> /
>     Leif

OK I'll move this one. In general I don't know which ones are generic
and I'd rather keep them x86-specific unless we know.

Regards,
Simon