[PATCH 00/20] gitlab: Simplify the test script
sjg at chromium.org
Sun Mar 15 16:07:48 CET 2020
On Sun, 15 Mar 2020 at 07:02, Tom Rini <trini at konsulko.com> wrote:
> On Sat, Mar 14, 2020 at 09:10:09PM -0600, Simon Glass wrote:
> > Hi Tom,
> > On Mon, 9 Mar 2020 at 11:55, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Fri, Mar 06, 2020 at 08:07:14PM -0700, Simon Glass wrote:
> > >
> > > > At present there are several things in the gitlab script which work around
> > > > limitations in buildman. With a few small feature additions these can be
> > > > removed.
> > > >
> > > > This series adds some new features to buildman and simplifies the script:
> > > > - Option to run a single build in a specified output directory
> > > > - Allow ignoring warnings
> > > > - Removes a restriction on the build output directory
> > > >
> > > > It also
> > > > - moves test.py over to use buildman for the --build option
> > > > - makes one change to azure since the same approach should be possible there
> > > > - fixes a few minor problems noticed in main and sandbox docs
> > >
> > > One general comment is that while it's clear from this series that
> > > you're focusing on test.py invocation most of the time, a lot of the
> > > commit messages aren't clear that you're changing the
> > > buildman_and_testpy_template stanza.
> > I'm not sure what you are looking for there. Do you want the commit
> > message to mention which part of the gitlab file is being changed?
> I mean a lot of places say something like "Change gitlab ..." but aren't
> changing any of the world builds, only test.py stuff, so I would prefer
> "Change gitlab when using test.py ..."
OK I will try. I've got the changes to all three environments in a
single commit at present, so we don't end up with double the commis.
Or would you prefer it split out?
One more thing...I notice that gitlab and azure use 'set -ex' to avoid
needing to check errors in the script. Is is possible for travis to do
that do, or is there some restriction?
More information about the U-Boot