[PATCH v2 19/23] travis/gitlab/azure: Drop the -E flag

Tom Rini trini at konsulko.com
Mon Mar 16 22:21:36 CET 2020


On Sun, Mar 15, 2020 at 05:42:59PM -0600, Simon Glass wrote:

> It doesn't seem to make sense to tell buildman to report warning as errors
> (thus ensuring there are no warnings) and then ignore the warnings.
> 
> The simplist thing is to just drop the -E flag. This allows us to drop the
> check for exit code 129.
> 
> Dropping -E is not enough to cover all warnings though. For example this
> warning:
> 
>     ===================== WARNING ======================
>     This board does not use CONFIG_DM. CONFIG_DM will be
>     compulsory starting with the v2020.01 release.
>     Failure to update may result in board removal.
>     See doc/driver-model/migration.rst for more info.
> 
> also causes buildman to return an exit code of 129. So use -W to suppress
> that, since otherwise the build will fail.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Fixes: 329f5ef51d2 (travis.yml: run buildman with option -E)

Ah, we have something funny going on, or at least not clear enough.  We
need and want -E here as that causes us to build with -Werror and so
warnings become errors and the build fails.  We still ignore warnings
such as "go convert X to DM" (which is its own issue to deal with) and
also dtc warnings (which is its own issue to deal with).

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200316/b768e0c9/attachment.sig>


More information about the U-Boot mailing list