[PATCH 00/12] net: smc911x: Convert to DM

Masahiro Yamada yamada.masahiro at socionext.com
Tue Mar 17 07:17:46 CET 2020


Hi Marek,


On Mon, Mar 16, 2020 at 1:59 AM Marek Vasut <marek.vasut at gmail.com> wrote:
>
> Perform DM conversion of the SMC911x driver. Note that as I do not have
> any hardware with this chip, I only compile-tested this conversion. But
> it seems Yamada-san has one, so please test.

With a quick test on my board, it worked for me.

I will leave comments to each patch, but
they are mostly nit-picking.

Thanks for the cleanups and the conversion.




>
> Note that the DT compatible is set only for 9115 , so this might need
> to be changed.
>
> Note that this is compile-tested, but not hardware tested, so please do
> send me patches, thanks.
>
> Marek Vasut (12):
>   net: smc911x: Remove pkt_data_{push,pull}
>   net: smc911x: Replace malloc()+memset() with calloc()
>   net: smc911x: Rename smc911x_rx() to smc911x_recv()
>   net: smc911x: Invert the logic in smc911x_miiphy_{read,write}()
>   net: smc911x: Fix potential memleak() in init fail path
>   net: smc911x: Inline all functions from header file
>   net: smc911x: Drop weak alias from 32bit accessors
>   net: smc911x: Convert IO accessors to {read,write}{w,l}()
>   net: smc911x: Pass around driver private data
>   net: smc911x: Clean up the status handling in smc911x_recv()
>   net: smc911x: Split non-DM specific bits from common code
>   net: smc911x: Add DM support
>
>  board/renesas/blanche/blanche.c      |   2 +
>  drivers/net/smc911x.c                | 523 +++++++++++++++++++++------
>  drivers/net/smc911x.h                | 157 --------
>  examples/standalone/Makefile         |   5 +-
>  examples/standalone/smc911x_eeprom.c | 150 ++++++++
>  5 files changed, 577 insertions(+), 260 deletions(-)
>
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
>
> --
> 2.25.0
>


-- 
Best Regards
Masahiro Yamada


More information about the U-Boot mailing list