[PATCH 06/12] net: smc911x: Inline all functions from header file

Masahiro Yamada yamada.masahiro at socionext.com
Tue Mar 17 07:25:47 CET 2020


On Mon, Mar 16, 2020 at 2:00 AM Marek Vasut <marek.vasut at gmail.com> wrote:
>
> Inline all the functions from the header file, as they are not used
> outside of the driver or the standalone EEPROM example.

Meh for 'static inline' in .c files,
but you will rip it off in the next commit.
So, the resulted code seems good.

(I would drop inline when I move the code, though...)




>
> Note that this does introduce considerable amount of duplication in
> the standalone EEPROM example, however that one has to be rewritten
> anyway, roughly such that the SMC911x driver would expose DM EEPROM
> interface and the standalone example would use that.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas at gmail.com>
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---


--
Best Regards

Masahiro Yamada


More information about the U-Boot mailing list