[PATCH] mach-snapdragon: Fix overwriting last digit of serial number

Jan-Christoph Tebbe jan-christoph.tebbe at ithinx.io
Mon Mar 16 17:51:51 CET 2020


When generating the MAC address based on the boards serial number
the last digit was overwritten with the null termination. That way
boards with serial numbers close to each other would use the same
MAC address.

Signed-off-by: Jan-Christoph Tebbe <Jan-Christoph.Tebbe at ithinx.io>
---
 arch/arm/mach-snapdragon/misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-snapdragon/misc.c b/arch/arm/mach-snapdragon/misc.c
index f6c87866c0..aaa561c2c6 100644
--- a/arch/arm/mach-snapdragon/misc.c
+++ b/arch/arm/mach-snapdragon/misc.c
@@ -41,7 +41,7 @@ void msm_generate_mac_addr(u8 *mac)
  int i;
  char sn[9];

- snprintf(sn, 8, "%08x", msm_board_serial());
+ snprintf(sn, 9, "%08x", msm_board_serial());

  /* fill in the mac with serialno, use locally adminstrated pool */
  mac[0] = 0x02;
-- 
2.17.1


More information about the U-Boot mailing list