[PATCH] powerpc: remove WATCHDOG_RESET call from wait_ticks()

Christophe Leroy christophe.leroy at c-s.fr
Tue Mar 17 14:21:45 CET 2020



Le 17/03/2020 à 14:07, Rasmus Villemoes a écrit :
> 
>> In any case it seems to me a board specific redefinition of the
>> WATCHDOG_RESET macro would be less intrusive and risky than changing
>> code that has been there since the beginning of time (well, at least
>> more than 18 years).
> 
> The point is, we're being told that everything is moving to DM and
> better convert your board or else..., and nowadays CONFIG_WDT comes with
> it's own watchdog_reset() which is a rather more complicated beast than
> the board-specific ones that used to be sprinkled throughout (and
> out-of) the tree. So yes, for the past 18 years, nothing bad has
> probably come from doing a WATCHDOG_RESET even deep down in the guts of
> arch-specific primitives.
> 

CONFIG_WDT comes with a watchdog_reset() when you defined CONFIG_WATCHDOG.

For boards like powerpc boards with embedded SOC watchdog that needs to 
be pinged from the very begining, we have CONFIG_HW_WATCHDOG and that's 
compatible with DM. See 
https://gitlab.denx.de/u-boot/u-boot/-/commit/a68256074f4239008c6d5c936bc0f8857f3d1b8a

Christophe


More information about the U-Boot mailing list